Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagemagick: 6.9.11-29 -> 6.9.11-60 #111287

Merged
merged 3 commits into from Jan 31, 2021
Merged

imagemagick: 6.9.11-29 -> 6.9.11-60 #111287

merged 3 commits into from Jan 31, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

fixes #109184 and fixes #100302

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 30, 2021
@dotlambda dotlambda mentioned this pull request Jan 30, 2021
Closed
10 tasks
@tomberek
Copy link
Contributor

tomberek commented Jan 30, 2021 •
edited

Result of nixpkgs-review pr 111287 run on x86_64-linux 1

1 package built:
  • imagemagick

Only tested imagemagick binaries, not further dependencies.

taku0
taku0 approved these changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert works fine on Linux and macOS.

@ajs124 ajs124 removed their request for review January 31, 2021 11:45
@SuperSandro2000 SuperSandro2000 merged commit 3ef8a64 into NixOS:master Jan 31, 2021
@dotlambda dotlambda deleted the imagemagick6-6.9.11-57 branch January 31, 2021 22:21
@dotlambda
Copy link
Member Author

backport: #111502

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
6 participants
@dotlambda @tomberek @taku0 @SuperSandro2000 @TredwellGit @ajs124