Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/silence warning from flake8-bugbear. #187

Merged
merged 3 commits into from Feb 2, 2021
Merged

Fix/silence warning from flake8-bugbear. #187

merged 3 commits into from Feb 2, 2021

Conversation

frosch123
Copy link
Member

None of the fixes are critical. But the noise in "make flake" annoys me :)

glx22
glx22 approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FLHerne
FLHerne reviewed Jan 30, 2021
View reviewed changes
Copy link
Contributor

@FLHerne FLHerne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one comment.

I considered nitpicking about some of the AssertionErrors where semantically ValueError might make sense, but meh.

nml/actions/action2layout.py Show resolved Hide resolved
@LordAro LordAro merged commit a42c3b0 into OpenTTD:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

@FLHerne FLHerne FLHerne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frosch123 @glx22 @FLHerne @LordAro