Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orchis: init at 2021-01-22 #111347

Merged
merged 2 commits into from Feb 22, 2021
Merged

orchis: init at 2021-01-22 #111347

merged 2 commits into from Feb 22, 2021

Conversation

fufexan
Copy link
Contributor

@fufexan fufexan commented Jan 30, 2021

Orchis is a Material Derign theme for GTK.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/data/themes/orchis/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/orchis/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/orchis/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/orchis/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@fufexan fufexan force-pushed the orchis-theme branch 3 times, most recently from aec6aed to 4e15d45 Compare January 30, 2021 20:33
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111347 run on x86_64-linux 1

1 package built:
  • orchis

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

orchis:

An avoidable string conversion got detected: rev = "${version}";
Please do not convert variable to a string without adding a string like v.

@fufexan
Copy link
Contributor Author

fufexan commented Feb 1, 2021

Would replacing rev = "${version}"; with rev = version; be considered alright?

@SuperSandro2000
Copy link
Member

Would replacing rev = "${version}"; with rev = version; be considered alright?

Yeah that totally fine. I should add it to the text.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 1, 2021

Does it work without sassc? It is listed in the readme as a dependency.

@fufexan
Copy link
Contributor Author

fufexan commented Feb 1, 2021

It installs fine. I think sassc is required to compile the sass files, but it all seems to work alright even without it.

@fufexan
Copy link
Contributor Author

fufexan commented Feb 21, 2021

Can this be merged or do I need to do anything else? @SuperSandro2000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants