Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] tcsh: broken source links due to newer version #111271

Merged
merged 1 commit into from Jan 31, 2021
Merged

[20.09] tcsh: broken source links due to newer version #111271

merged 1 commit into from Jan 31, 2021

Conversation

twhitehead
Copy link
Contributor

Motivation for this change

Source URL for tcsh has changed now that a new version has been released (moved to the old subdirectory).

Things done

Updated URL.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

Please base the PR against release-20.09. There's no need to put it into staging first.

@twhitehead twhitehead changed the base branch from staging-20.09 to release-20.09 January 31, 2021 04:02
@twhitehead
Copy link
Contributor Author

Done. Thanks!

I guess the master branch should probably have both the regular and old URLs. I've seen this in other packages. That way, when a version is moved to old, the downloads still keep working.

@markuskowa markuskowa changed the title tcsh: broken source links due to newer version [20.09] tcsh: broken source links due to newer version Jan 31, 2021
@markuskowa
Copy link
Member

I guess the master branch should probably have both the regular and old URLs. I've seen this in other packages. That way, when a version is moved to old, the downloads still keep working.

Yes, that sounds like a good idea.

@markuskowa markuskowa merged commit 7ef22de into NixOS:release-20.09 Jan 31, 2021
@twhitehead twhitehead deleted the tcsh branch January 31, 2021 16:15
@twhitehead
Copy link
Contributor Author

twhitehead commented Jan 31, 2021 •
edited

Thanks. Submitted #111479 to add the old subdirectories to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twhitehead @markuskowa