Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Adding Yugabyte DB. #111337

Closed
wants to merge 1 commit into from
Closed

WIP Adding Yugabyte DB. #111337

wants to merge 1 commit into from

Conversation

kevincox
Copy link
Contributor

@kevincox kevincox commented Jan 30, 2021 •
edited

I couldn't get it to build but am pushing the WIP.

Other (incompletely) packaged things for people searching:

pkgs/development/libraries/cds/default.nix | 26 +++++++++++++++
pkgs/development/libraries/crcutil/default.nix | 41 +++++++++++++++++++++++
pkgs/development/libraries/crypt_blowfish/default.nix | 31 +++++++++++++++++
pkgs/development/libraries/squeasel/default.nix | 42 +++++++++++++++++++++++
pkgs/servers/sql/yugabyte/default.nix | 117 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
pkgs/top-level/all-packages.nix

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kevincox
WIP Adding Yugabyte DB.
2100fcd 
I couldn't get it to build but am pushing the WIP.
@kevincox kevincox self-assigned this Jan 30, 2021
@kevincox kevincox closed this Jan 30, 2021
@SuperSandro2000 SuperSandro2000 deleted the yugabyte branch January 30, 2021 20:02
@SuperSandro2000
Copy link
Member

Please do not create branches in the repo. It is not manageable with so many commiters.

@kevincox
Copy link
Contributor Author

Sorry, I forgot to delete it. Is this a new policy? Is it written down anywhere? Does this apply for ongoing work and pull requests or only dead pull requests?

@SuperSandro2000
Copy link
Member

No, it isn't but please use a fork for PRs. Otherwise this repo would have have hundreds of branches no one knows what to do with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kevincox kevincox

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevincox @SuperSandro2000