Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/development: stdenv.lib -> lib in node-composition files #111247

Merged
merged 1 commit into from Jan 30, 2021
Merged

pkgs/development: stdenv.lib -> lib in node-composition files #111247

merged 1 commit into from Jan 30, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 30, 2021 •
edited

Future updates to these files should generate them with node2nix 1.9.0
which removes stdenv.lib from the generated Nix.

Part of #108938

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben requested a review from Mic92 January 30, 2021 02:45
@siraben siraben force-pushed the stdenv-lib-node-env branch 2 times, most recently from bdad918 to 0e41b49 Compare January 30, 2021 04:11
@siraben
Copy link
Member Author

siraben commented Jan 30, 2021

Result of nixpkgs-review pr 111247 run on x86_64-darwin 1

@siraben
Copy link
Member Author

siraben commented Jan 30, 2021 •
edited

No rebuilds.

EDIT: it appears nixpkgs-review doesn't evaluate everything, going with ofborg

@siraben siraben force-pushed the stdenv-lib-node-env branch 2 times, most recently from 4719c97 to cf78b91 Compare January 30, 2021 04:34
@siraben
pkgs/development: stdenv.lib -> lib in node-composition files
32fc8b9 
Future updates to these files should generate them with node2nix 1.9.0
which removes stdenv.lib from the generated Nix.
@Mic92 Mic92 merged commit fd2dcf3 into NixOS:master Jan 30, 2021
@Mic92
Copy link
Member

Mic92 commented Jan 30, 2021

No rebuilds.

EDIT: it appears nixpkgs-review doesn't evaluate everything, going with ofborg

It only evaluates for the current platform.

@siraben siraben deleted the stdenv-lib-node-env branch January 30, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @Mic92