Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.48.0 -> 0.49.0 #111243

Merged
merged 1 commit into from Jan 30, 2021
Merged

starship: 0.48.0 -> 0.49.0 #111243

merged 1 commit into from Jan 30, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 30, 2021

Motivation for this change

https://github.com/starship/starship/releases/tag/v0.49.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbigras
Copy link
Contributor

bbigras commented Jan 30, 2021

Result of nixpkgs-review pr 111243 run on x86_64-linux 1

1 package failed to build:
  • starship

@bbigras
Copy link
Contributor

bbigras commented Jan 30, 2021

I got some test failing:

builder for '/nix/store/dpfs8k01sawic90bnx0p3xi9h0ph9cmz-starship-0.49.0.drv' failed with exit code 101; last 10 log lines:
      modules::username::tests::ssh_connection
      modules::username::tests::ssh_connection_client
      modules::username::tests::ssh_connection_tty
      modules::username::tests::ssh_wo_username
      modules::zig::tests::folder_with_zig_file
      modules::zig::tests::folder_without_zig

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 111243 run on x86_64-linux 1

1 package built:
  • starship

@marsam marsam merged commit b375887 into NixOS:master Jan 30, 2021
@marsam marsam deleted the update-starship branch January 30, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frostman Frostman Awaiting requested review from Frostman

@bbigras bbigras Awaiting requested review from bbigras

@davidtwco davidtwco Awaiting requested review from davidtwco

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @bbigras @tomberek