Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-appservice-slack: 1.4.0 -> 1.7.0 #111346

Merged
merged 4 commits into from Apr 2, 2021
Merged

matrix-appservice-slack: 1.4.0 -> 1.7.0 #111346

merged 4 commits into from Apr 2, 2021

Conversation

beardhatcode
Copy link
Contributor

@beardhatcode beardhatcode commented Jan 30, 2021 •
edited

Motivation for this change

Bump to the last version I found that compiled...

if anyone is able to get 1.6.2 working in nix, that would be great. I think this works, but I don't have a working setup yet... (but it is most likely a config error on my side)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@beardhatcode beardhatcode marked this pull request as draft February 1, 2021 21:08
@beardhatcode beardhatcode changed the title matrix-appservice-slack: 1.4.0 -> 1.6.1 (help wanted) matrix-appservice-slack: 1.4.0 -> 1.7.0 Feb 13, 2021
@beardhatcode beardhatcode marked this pull request as ready for review February 13, 2021 21:15
@beardhatcode
Copy link
Contributor Author

I finally figured out how to update this. And it is now running on my server.

@beardhatcode
maintainers: add beardhatcode
045e01a 
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
@beardhatcode
matrix-appservice-slack: Add beardhatcode as maintainer
8e4131e 
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
@expipiplus1
Copy link
Contributor

@beardhatcode Do you happen to have a nixos module to share for this?

@beardhatcode
Copy link
Contributor Author

I have something like this: https://gist.github.com/beardhatcode/ce57d04da1ec482057a3ac54519359ee/revisions

@beardhatcode @SuperSandro2000
Use tag instead of sha to reference upstream pacakge.json
4c8b69b 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 SuperSandro2000 merged commit bc0144e into NixOS:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beardhatcode @expipiplus1 @SuperSandro2000