gradle: 6.7 -> 6.8.1 #111311
gradle: 6.7 -> 6.8.1 #111311
Conversation
lorenzleutgeb
force-pushed
the
gradle-6.8.1
branch
from
58b2678
to
e9cacc6
Compare
lorenzleutgeb
force-pushed
the
gradle-6.8.1
branch
from
e9cacc6
to
54bf37a
Compare
| @@ -88,7 +88,7 @@ let | |||
| ''; | |||
|
|
|||
| # The default one still uses jdk8 (#89731) | |||
| gradle_6 = (gradleGen.override (old: { java = jdk; })).gradle_6_7; | |||
| gradle_6 = (gradleGen.override (old: { java = jdk; })).gradle_6_8; | |||
There was a problem hiding this comment.
we can just use gradle_latest here (with the jdk override) now that 6 is the default
There was a problem hiding this comment.
We should verify the fixed-output derivations can still be built using the new version.
There was a problem hiding this comment.
If I can be of help here, please just tell me, otherwise I'll relax until you know exactly what you want to do :)
There was a problem hiding this comment.
Sure, @fgaz and I will discuss it and tell you when we have a good solution.
I think we should keep it set to a fixed version, so that we are notified when the version changes, because it's not so unlikely that gradle updates break the fixed-output derivation build without us noticing.
@fgaz do you agree or would you prefer to set it to latest regardless and just look out for gradle updates carefully?
There was a problem hiding this comment.
@petabyteboy I never saw a hash change happen on other gradle packages, but I agree that it could be more likely here. And we get notified anyway...
There was a problem hiding this comment.
Hmm, maybe I should also switch my other gradle packages to a fixed gradle
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 7 packages marked as broken and skipped:
4 packages built:
|
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package marked as broken and skipped:
10 packages built:
|
Motivation for this change
New Gradle release(s). Previous version packaged was 6.7, this MR packages 6.8.1, versions 6.7.1 and 6.8 have been released in the meantime. Notes:
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Mentioning some people that are likely to review/merge, hope that's okay:
mindustry, which referencedgradle_6_7explicitly. I changed this reference togradle_6_8, which should be reasonably safe.Let's keep Gradle fresh :)