Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

herbstluftwm: Add option to specify package #111312

Merged
merged 1 commit into from Feb 10, 2021
Merged

herbstluftwm: Add option to specify package #111312

merged 1 commit into from Feb 10, 2021

Conversation

fdietze
Copy link
Contributor

@fdietze fdietze commented Jan 30, 2021

Motivation for this change

Be able to use the latest unstable version of herbstluftwm as my window manager.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

iblech
iblech approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@iblech iblech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for a fast-moving window manager like herbstluftwm the flexibility supported by your pull request is very nice to have. Thank you for your work! :-)

aanderse
aanderse reviewed Jan 31, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't an overlay work for you?

nixos/modules/services/x11/window-managers/herbstluftwm.nix Outdated Show resolved Hide resolved
@fdietze
Copy link
Contributor Author

fdietze commented Feb 2, 2021

Didn't an overlay work for you?

I'm not experienced enough in nixos to answer that question. I didn't try overlays and was already happy to get it working this way.

@aanderse
Copy link
Member

aanderse commented Feb 2, 2021

@fdietze say you had a the following 2 channels defined:

~> sudo nix-channel --list                                                                                                                                                                                                                                 
nixos https://nixos.org/channels/nixos-20.09
unstable https://nixos.org/channels/nixos-unstable

You could add the following to your configuration.nix file:

{ config, pkgs, lib, ... }:
let
  nixosUnstable = import <nixosUnstable> {};
in
{
  nixpkgs.overlays = [
    (self: super: {
      herbstluftwm = unstable.herbstluftwm;
    })
  ];
}

This is one way you can utilize overlays.

@fdietze
Copy link
Contributor Author

fdietze commented Feb 5, 2021

@aanderse Thank you for the explanation!

aanderse
aanderse approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. At a quick glance this looks good to me 👍

@aanderse
Copy link
Member

aanderse commented Feb 5, 2021

Please squash and we can merge.

@fdietze
Copy link
Contributor Author

fdietze commented Feb 9, 2021

It's squashed and ready to merge.

@aanderse aanderse merged commit 5473527 into NixOS:master Feb 10, 2021
@aanderse
Copy link
Member

Thanks @fdietze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblech iblech iblech approved these changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fdietze @aanderse @iblech