Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: warn about use of inherited lib #111284

Merged
merged 6 commits into from Jan 31, 2021
Merged

stdenv: warn about use of inherited lib #111284

merged 6 commits into from Jan 31, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 30, 2021 •
edited

Motivation for this change

Closes #108938

  • Remove re-introduced stdenv.lib instances
  • Removed lib from stdenv (doing this to check ofborg eval)
  • warn about use of inherited lib
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben changed the title treewide: remove lib from stdenv treewide: stdenv.lib -> lib, stdenv: remove inherited lib Jan 30, 2021
@ofborg ofborg bot added the 6.topic: stdenv Standard environment label Jan 30, 2021
@siraben siraben changed the title treewide: stdenv.lib -> lib, stdenv: remove inherited lib stdenv: remove inherited lib Jan 30, 2021
@siraben siraben force-pushed the remove-new-stdenv-lib branch 2 times, most recently from 8f61ce9 to c96f3cd Compare January 30, 2021 11:26
@siraben siraben changed the title stdenv: remove inherited lib stdenv: warn about use of inherited lib Jan 30, 2021
worldofpeace
worldofpeace suggested changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good but I think we need a release note to document that we're phasing out stdenv.lib.

@siraben
Copy link
Member Author

siraben commented Jan 30, 2021

All good but I think we need a release note to document that we're phasing out stdenv.lib.

Which files would I need to do this in?

Ericson2314
Ericson2314 approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind CI has failed deprecation warnings before, with things like == forcing the thunks for otherwise unaccessed attributes, but I hope this one will work out :).

@siraben @Ericson2314
Update pkgs/stdenv/generic/default.nix
227693e 
Co-authored-by: John Ericson <git@JohnEricson.me>
@Ericson2314 Ericson2314 merged commit 6717246 into NixOS:master Jan 31, 2021
@Atemu
Copy link
Member

Atemu commented Feb 1, 2021

things like == forcing the thunks for otherwise unaccessed attributes

Could that be what's causing #109001?

@siraben siraben deleted the remove-new-stdenv-lib branch February 1, 2021 08:05
samueldr added a commit to samueldr-wip/mobile-nixos-wip that referenced this pull request Feb 2, 2021
@samueldr
Fix stdenv.lib being removed
4eb06f0 
Deals with NixOS/nixpkgs#111284
@samueldr samueldr mentioned this pull request Feb 2, 2021
Merged
samueldr added a commit to samueldr-wip/mobile-nixos-wip that referenced this pull request Feb 2, 2021
@samueldr
Fix stdenv.lib being removed
225ed39 
Deals with NixOS/nixpkgs#111284
@andersk andersk mentioned this pull request Feb 19, 2021
Merged
@Artturin Artturin mentioned this pull request May 8, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: stdenv Standard environment 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate use of stdenv.lib across Nixpkgs
4 participants
@siraben @Atemu @Ericson2314 @worldofpeace