Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/networkd: add missing IPv6 options #111342

Merged
merged 5 commits into from Feb 26, 2021
Merged

nixos/networkd: add missing IPv6 options #111342

merged 5 commits into from Feb 26, 2021

Conversation

veehaitch
Copy link
Member

@veehaitch veehaitch commented Jan 30, 2021 •
edited

Motivation for this change

Adds various missing/renamed configuration sections/options for systemd-networkd related to IPv6.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veehaitch
nixos/networkd: add missing dhcpV6Config options
53033aa
@veehaitch
nixos/networkd: add dhcpV6PrefixDelegationConfig option
38f19af 
networkd gained a new section [DHCPv6PrefixDelegation] which
controls delegated prefixes assigned by DHCPv6 client. Added in systemd
246.
@veehaitch
nixos/networkd: add ipv6AcceptRAConfig option
7351114 
Adds `systemd.network.networks.*.ipv6AcceptRAConfig` for networkd's
[IPv6AcceptRA] section.
@veehaitch
nixos/networkd: rename ipv6PrefixDelegationConfig option to ipv6SendR…
e6660ff 
…AConfig

networkd's [IPv6PrefixDelegation] section and IPv6PrefixDelegation=
options have been renamed as [IPv6SendRA] and IPv6SendRA= in systemd
247.

Throws if the deprecated option ipv6PrefixDelegationConfig is used.
@veehaitch
Copy link
Member Author

@GrahamcOfBorg test systemd-networkd-ipv6-prefix-delegation

@veehaitch
Copy link
Member Author

@GrahamcOfBorg test systemd-networkd-ipv6-prefix-delegation

@veehaitch veehaitch requested a review from andir January 31, 2021 00:54
@veehaitch
Copy link
Member Author

If there's anything I can do to advance this PR, feel free to reach out. Happy to help :)

@flokli flokli merged commit aed9171 into NixOS:master Feb 26, 2021
@veehaitch veehaitch deleted the systemd-networkd-options branch February 26, 2021 23:35
@andir
Copy link
Member

andir commented Mar 2, 2021

This is missing changelog entries. Would be nice to point users towards this before they run into crypto eval errors (that do not point out the right lines :/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

@flokli flokli Awaiting requested review from flokli

@picnoir picnoir Awaiting requested review from picnoir

@arianvp arianvp Awaiting requested review from arianvp

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veehaitch @andir @flokli