zinit: 2.3 -> 3.7 #111295
Merged
zinit: 2.3 -> 3.7 #111295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jan 30, 2021
pkgs/shells/zsh/zinit/default.nix
Outdated
Comment on lines
1
to
3
| { stdenvNoCC, lib, fetchFromGitHub, installShellFiles }: | ||
| stdenvNoCC.mkDerivation rec { |
There was a problem hiding this comment.
Suggested change
| { stdenvNoCC, lib, fetchFromGitHub, installShellFiles }: | |
| stdenvNoCC.mkDerivation rec { | |
| { stdenvNoCC, lib, fetchFromGitHub, installShellFiles }: | |
| stdenvNoCC.mkDerivation rec { |
pkgs/top-level/aliases.nix
Outdated
Comment on lines
843
to
844
| # Added 2021-01-30 | ||
| zplugin = zinit; |
There was a problem hiding this comment.
Suggested change
| # Added 2021-01-30 | |
| zplugin = zinit; | |
| zplugin = zinit; # Added 2021-01-30 |
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package failed to build and already failed to build on hydra master:
|
|
nixpkgs-review pr 111295
1 package built:
zinit |
ivankovnatsky
approved these changes
Feb 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Apparently @zdharmha did rename zplugins tozinit, breaking any auto upgrade there was
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)