Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nomachine-client: 6.12.3 -> 7.0.211 #111296

Merged
merged 1 commit into from Jan 30, 2021
Merged

[20.09] nomachine-client: 6.12.3 -> 7.0.211 #111296

merged 1 commit into from Jan 30, 2021

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jan 30, 2021

Motivation for this change

Port #110632 to stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@austinbutler @talyz
nomachine-client: 6.12.3 -> 7.0.211
1cdaaa6 
(cherry picked from commit 0013820)
@austinbutler
Copy link
Member

Dumb question, does a major version bump like this in a stable channel not break any rules? I've mostly just paid attention to unstable channel so not as familiar with the criteria for stable channels.

@talyz
Copy link
Contributor Author

talyz commented Jan 30, 2021

Normally, we don't commit any major changes to stable, but sometimes it has to be done - for example when there's a security issue which is only solved in a major update or the old version becomes unavailable, like with NoMachine. In this case, it's also completely isolated, since no other packages are dependent on NoMachine.

@austinbutler
Copy link
Member

Makes sense, thank you!

@austinbutler
Copy link
Member

Result of nixpkgs-review pr 111296 run on x86_64-linux 1

1 package built:
  • nomachine-client

@Mic92 Mic92 merged commit 525d9ef into NixOS:release-20.09 Jan 30, 2021
@talyz talyz deleted the nomachine-7-20.09 branch February 1, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinbutler austinbutler austinbutler approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talyz @austinbutler @Mic92