Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDE Frameworks 5.78 #111325

Merged
merged 4 commits into from Feb 4, 2021
Merged

KDE Frameworks 5.78 #111325

merged 4 commits into from Feb 4, 2021

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Jan 30, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Should this go through staging?

@ttuegel
Copy link
Member Author

ttuegel commented Jan 30, 2021

Yes.

@ttuegel
Copy link
Member Author

ttuegel commented Feb 4, 2021

@ofborg eval

@ttuegel
Copy link
Member Author

ttuegel commented Feb 4, 2021

The Nixpkgs manual build seems to time-out on the staging branch, but this isn't related to any of my changes and I don't think it should hold up this pull request.

@ttuegel ttuegel merged commit 1814894 into NixOS:staging Feb 4, 2021
@ttuegel ttuegel deleted the kde-frameworks-5.78 branch February 4, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants