Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-provider-kafka: init at v0.2.12 #111301

Merged
merged 1 commit into from Feb 4, 2021
Merged

terraform-provider-kafka: init at v0.2.12 #111301

merged 1 commit into from Feb 4, 2021

Conversation

rguevara84
Copy link
Contributor

@rguevara84 rguevara84 commented Jan 30, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member

@GrahamcOfBorg build terraform.full

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111301 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • terraform-full
1 package failed to build and are new build failure:

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111301 run on x86_64-linux 1

2 packages failed to build and are new build failures:

@rguevara84
Copy link
Contributor Author

What's the process for this case where the vendor files are missing, locally I had to run go mod vendor, I see there is an option for go modules to force the dependencies to be downloaded, but that kind of applies to all providers, how can I enable that flag just for a single provider. https://nixos.org/manual/nixpkgs/stable/#ex-buildGoModule
runVend = true;

@timstott
Copy link
Contributor

timstott commented Feb 3, 2021

@rguevara84 You may override attributes for a specific provider as it is done with acme, see

https://github.com/nixos/nixpkgs/blob/993bbf7581527a8be13713e34d495127a9fc88d9/pkgs/applications/networking/cluster/terraform-providers/default.nix#L48-L54

@rguevara84
Copy link
Contributor Author

what attribute should I override? I tried

kafka = automated-providers.kafka.overrideAttrs (attrs: {
      deleteVendor = true;
      runVend = true;
    });

Aren't those at the same level as prepatch, postBuild, and friends attributes?
While debugging the build I can see some attributes but not the ones I'm looking for, is any of those equivalent to deleteVendor and runVend ?
Any advice I'm kind of lost here :_(

processing attribute 'allowSubstitutes'
processing attribute 'args'
processing attribute 'buildCommand'
processing attribute 'buildInputs'
processing attribute 'builder'
processing attribute 'configureFlags'
processing attribute 'depsBuildBuild'
processing attribute 'depsBuildBuildPropagated'
processing attribute 'depsBuildTarget'
processing attribute 'depsBuildTargetPropagated'
processing attribute 'depsHostHost'
processing attribute 'depsHostHostPropagated'
processing attribute 'depsTargetTarget'
processing attribute 'depsTargetTargetPropagated'
processing attribute 'doCheck'
processing attribute 'doInstallCheck'
processing attribute 'executable'
processing attribute 'name'
processing attribute 'nativeBuildInputs'
processing attribute 'outputs'
processing attribute 'passAsFile'
processing attribute 'patches'
processing attribute 'preferLocalBuild'
processing attribute 'propagatedBuildInputs'
processing attribute 'propagatedNativeBuildInputs'
processing attribute 'stdenv'
processing attribute 'strictDeps'
processing attribute 'system'
processing attribute 'text'
processing attribute 'CGO_ENABLED'
processing attribute 'GO111MODULE'
processing attribute 'GO386'
processing attribute 'GOARCH'
processing attribute 'GOARM'
processing attribute 'GOFLAGS'
processing attribute 'GOHOSTARCH'
processing attribute 'GOHOSTOS'
processing attribute 'GOOS'
processing attribute 'args'
processing attribute 'buildInputs'
processing attribute 'buildPhase'
processing attribute 'builder'
processing attribute 'checkPhase'
processing attribute 'configureFlags'
processing attribute 'configurePhase'
processing attribute 'depsBuildBuild'
processing attribute 'depsBuildBuildPropagated'
processing attribute 'depsBuildTarget'
processing attribute 'depsBuildTargetPropagated'
processing attribute 'depsHostHost'
processing attribute 'depsHostHostPropagated'
processing attribute 'depsTargetTarget'
processing attribute 'depsTargetTargetPropagated'
processing attribute 'disallowedReferences'
processing attribute 'doCheck'
processing attribute 'doInstallCheck'
processing attribute 'enableParallelBuilding'
processing attribute 'enableParallelChecking'
processing attribute 'goPackagePath'
processing attribute 'installPhase'
processing attribute 'name'
processing attribute 'nativeBuildInputs'
processing attribute 'outputs'
processing attribute 'patches'
processing attribute 'pname'
processing attribute 'postBuild'
processing attribute 'propagatedBuildInputs'
processing attribute 'propagatedNativeBuildInputs'
processing attribute 'renameImports'
processing attribute 'shellHook'
processing attribute 'src'
processing attribute 'SSL_CERT_FILE'
processing attribute 'args'
processing attribute 'buildInputs'
processing attribute 'builder'
processing attribute 'configureFlags'
processing attribute 'curlOpts'
processing attribute 'depsBuildBuild'
processing attribute 'depsBuildBuildPropagated'
processing attribute 'depsBuildTarget'
processing attribute 'depsBuildTargetPropagated'
processing attribute 'depsHostHost'
processing attribute 'depsHostHostPropagated'
processing attribute 'depsTargetTarget'
processing attribute 'depsTargetTargetPropagated'
processing attribute 'doCheck'
processing attribute 'doInstallCheck'
processing attribute 'downloadToTemp'
processing attribute 'executable'
processing attribute 'impureEnvVars'
processing attribute 'mirrorsFile'
processing attribute 'name'
processing attribute 'nativeBuildInputs'
processing attribute 'nixpkgsVersion'
processing attribute 'outputHash'
processing attribute 'outputHashAlgo'
processing attribute 'outputHashMode'
processing attribute 'outputs'
processing attribute 'patches'
processing attribute 'postFetch'
processing attribute 'postHook'
processing attribute 'preferHashedMirrors'
processing attribute 'preferLocalBuild'
processing attribute 'propagatedBuildInputs'
processing attribute 'propagatedNativeBuildInputs'
processing attribute 'showURLs'
processing attribute 'stdenv'
processing attribute 'strictDeps'
processing attribute 'system'
processing attribute 'urls'
processing attribute 'userHook'

@kalbasit
Copy link
Member

kalbasit commented Feb 3, 2021

@rguevara84 not sure if you can override these attributes. I think that you'll have to add it as a custom package or add support for passing these attributes in the json.

@timstott
Copy link
Contributor

timstott commented Feb 4, 2021

@rguevara84 Sorry for pointing you in the wrong direction. I thought we could override these attribute but as @kalbasit points out, and having looked at the Go module builder source, it doesn't seem to be the case.

Providing support to these attributes in the JSON would be nice as I'm sure other providers will have this issue. You will have to update the function to accept the attributes here, and their default value here.

@rguevara84
Copy link
Contributor Author

@GrahamcOfBorg build terraform.full

@kalbasit kalbasit merged commit 89136c1 into NixOS:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@timstott timstott Awaiting requested review from timstott

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rguevara84 @kalbasit @SuperSandro2000 @timstott