Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] firefox-bin: 84.0.2 -> 85.0 #111300

Merged
merged 1 commit into from Feb 8, 2021
Merged

[20.09] firefox-bin: 84.0.2 -> 85.0 #111300

merged 1 commit into from Feb 8, 2021

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 30, 2021

(cherry picked from commit 6229722)

Motivation for this change

#111047 for 20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@claudiiii @taku0
firefox-bin: 84.0.2 -> 85.0
7b5184b 
(cherry picked from commit 6229722)
mweinelt
mweinelt approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested under x86_64 and sway. LGTM.

@mweinelt mweinelt merged commit d3ef882 into NixOS:release-20.09 Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @mweinelt @claudiiii