Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

armagetronad: 0.2.8.3.5 -> 0.2.9.1.0 #111273

Merged
merged 2 commits into from Feb 3, 2021
Merged

armagetronad: 0.2.8.3.5 -> 0.2.9.1.0 #111273

merged 2 commits into from Feb 3, 2021

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Jan 30, 2021 •
edited

Motivation for this change

Updating armagetronad to latest and adding dedicated server with different compile flags.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 30, 2021
View reviewed changes
pkgs/games/armagetronad/default.nix Outdated Show resolved Hide resolved
pkgs/games/armagetronad/default.nix Outdated Show resolved Hide resolved
pkgs/games/armagetronad/default.nix Outdated Show resolved Hide resolved
pkgs/games/armagetronad/default.nix Outdated Show resolved Hide resolved
pkgs/games/armagetronad/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
@numinit numinit force-pushed the armagetronad branch 2 times, most recently from 4fd3cb6 to 73c30c7 Compare January 30, 2021 20:51
SuperSandro2000
SuperSandro2000 reviewed Jan 31, 2021
View reviewed changes
pkgs/games/armagetronad/default.nix Outdated

meta = with lib; {
homepage = "http://armagetronad.org";
description = "An multiplayer networked arcade racing game in 3D similar to Tron";
description = "A multiplayer networked arcade racing game in 3D similar to Tron";
maintainers = with maintainers; [ numinit ];
license = licenses.gpl2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl2Plus or gpl2Only?

@SuperSandro2000
Copy link
Member

Can you please split the commit into armagetronad: 0.2.8.3.5 -> 0.2.9.1.0 and armagetronad-dedicated: init at 0.2.9.1.0.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111273 run on x86_64-linux 1

2 packages built:
  • armagetronad
  • armagetronad-dedicated

@numinit
Copy link
Contributor Author

numinit commented Feb 3, 2021

Done.

@numinit numinit changed the title armagetronad: update to 0.2.9.1; add armagetronad-dedicated package armagetronad: 0.2.8.3.5 -> 0.2.9.1.0 Feb 3, 2021
@SuperSandro2000 SuperSandro2000 merged commit 2f79819 into NixOS:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@numinit @SuperSandro2000