Skip to content

ammonite: Add installCheckPhase #110517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ammonite: Add installCheckPhase #110517

wants to merge 1 commit into from
+13 −2

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Add testing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@NeQuissimus NeQuissimus added the 6.topic: testing Tooling for automated testing of packages and modules label Jan 22, 2021
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 22, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110517 run on x86_64-darwin 1

3 packages failed to build and are new build failures:

@rmcgibbo
Copy link
Contributor

I think it's possible that there's an infinite loop here, but I'm not sure if that's really true or if so, why. I've had this build running for about 2 hours at 100% CPU usage, and it's still going.

@NeQuissimus
Copy link
Member Author

@rmcgibbo That's why this was still a draft PR. Something was whacky but I hadn't figured it out :D
tput was missing, so the output was infinite :)

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 23, 2021
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 23, 2021
@NeQuissimus NeQuissimus marked this pull request as ready for review January 23, 2021 21:49
@SuperSandro2000
Copy link
Member

@NeQuissimus build failed.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110517 run on x86_64-darwin 1

3 packages failed to build and are new build failures:

@NeQuissimus
ammonite: Add installCheckPhase

Verified

This commit was signed with the committer’s verified signature. The key has expired.
WilliButz
GPG key ID: 92582A10F1179CB2
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
01c7adc
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110517 run on x86_64-darwin 1

3 packages failed to build and are new build failures:

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110517 run on x86_64-linux 1

2 packages built:
  • ammonite (ammonite_2_13)
  • ammonite_2_12

@NeQuissimus
Copy link
Member Author

OK, something is up with this on Darwin. I will take a look

@NeQuissimus NeQuissimus marked this pull request as draft February 3, 2021 15:27
@NeQuissimus NeQuissimus self-assigned this Feb 3, 2021
@vobloeb vobloeb mentioned this pull request Feb 22, 2021
Closed
10 tasks
@stale
Copy link

stale bot commented Aug 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 2, 2021
@NeQuissimus NeQuissimus closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

Assignees

@NeQuissimus NeQuissimus

Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeQuissimus @SuperSandro2000 @rmcgibbo