Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/development/compilers: stdenv.lib -> lib #110465

Merged
merged 1 commit into from Jan 23, 2021
Merged

pkgs/development/compilers: stdenv.lib -> lib #110465

merged 1 commit into from Jan 23, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 22, 2021 •
edited

Motivation for this change

Part of #108938

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben force-pushed the development-compilers-stdenv-lib branch 10 times, most recently from e891143 to 372b205 Compare January 22, 2021 17:22
@jonringer
Copy link
Contributor

for verifying these changes don't cause regressions, do you mind doing:

TMPDIR=$(mktemp -d)
nix-instantiate --readonly-mode --eval --strict --show-trace --json ./maintainers/scripts/find-tarballs.nix --arg expr 'import ./maintainers/scripts/all-tarballs.nix' > $TMPDIR/tarballs.json

@jonringer
Copy link
Contributor

We had a channel blocker due to a deeply nested lib. https://hydra.nixos.org/build/135415084/nixlog/106

it was fixed in 59863dc

@siraben
Copy link
Member Author

siraben commented Jan 23, 2021

for verifying these changes don't cause regressions, do you mind doing:

TMPDIR=$(mktemp -d)
nix-instantiate --readonly-mode --eval --strict --show-trace --json ./maintainers/scripts/find-tarballs.nix --arg expr 'import ./maintainers/scripts/all-tarballs.nix' > $TMPDIR/tarballs.json

Thanks, I'm using this to find eval errors in my autofixing script now.

@siraben siraben force-pushed the development-compilers-stdenv-lib branch from 372b205 to acc5f7b Compare January 23, 2021 01:57
@siraben
Copy link
Member Author

siraben commented Jan 23, 2021

@jonringer please merge

@siraben
Copy link
Member Author

siraben commented Jan 23, 2021

@SuperSandro2000 rebuild 0

@Mic92 Mic92 merged commit f6a583e into NixOS:master Jan 23, 2021
@siraben siraben deleted the development-compilers-stdenv-lib branch January 23, 2021 12:28
@jonringer
Copy link
Contributor

sorry, I logged off for the day when you mentioned me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@kalbasit kalbasit Awaiting requested review from kalbasit kalbasit is a code owner

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: golang 6.topic: haskell 6.topic: rust 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @jonringer @Mic92