Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luarocks-nix: update 20190907 -> 20210122 #110467

Merged
merged 3 commits into from Jan 24, 2021
Merged

luarocks-nix: update 20190907 -> 20210122 #110467

merged 3 commits into from Jan 24, 2021

Conversation

teto
Copy link
Member

@teto teto commented Jan 22, 2021 •
edited

Motivation for this change

fixes #110157

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto teto mentioned this pull request Jan 22, 2021
Closed
10 tasks
@ofborg ofborg bot requested a review from 7c6f434c January 22, 2021 11:47
SuperSandro2000
SuperSandro2000 reviewed Jan 22, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the commit guide in the contributing guide: luarocks: old -> new

@teto
Copy link
Member Author

teto commented Jan 22, 2021

done

@teto
Copy link
Member Author

teto commented Jan 22, 2021

actually dont merge I need to change luarocks-nix since the output of nix-prefetch-git changed

@teto
luarocks-nix: update 20190907 -> 20210122
2db2a96 
rebased on top of luarocks 3.5
@teto
luaPackages.cassowary: add alerque as maintainer
e964e6e 
it was added in the generated file, move it to the source of truth for
the generated files.
@flokli flokli marked this pull request as draft January 22, 2021 23:20
@ofborg ofborg bot added the 6.topic: lua label Jan 22, 2021
@teto teto marked this pull request as ready for review January 23, 2021 13:35
@teto
Copy link
Member Author

teto commented Jan 23, 2021

@ofborg build luarocks-nix luaPackages.cassowary

@teto
Copy link
Member Author

teto commented Jan 23, 2021

should be good now

@SuperSandro2000 SuperSandro2000 changed the title Luarocks update luarocks-nix: update 20190907 -> 20210122 Jan 23, 2021
@SuperSandro2000

This comment has been minimized.

Sign in to view
@SuperSandro2000 SuperSandro2000 merged commit c58219f into NixOS:master Jan 24, 2021
@teto teto deleted the luarocks-update branch August 1, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maintainers/scripts/update-luarocks-packages uses stdenv.lib instead of lib and urls as non-strings
3 participants
@teto @SuperSandro2000 @flokli