Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.NetAsyncPing: skip ping socket tests #110556

Merged
merged 1 commit into from Jan 23, 2021
Merged

perlPackages.NetAsyncPing: skip ping socket tests #110556

merged 1 commit into from Jan 23, 2021

Conversation

zakame
Copy link
Member

@zakame zakame commented Jan 23, 2021

Motivation for this change

Skip ping socket tests for https://metacpan.org/pod/Net::Async::Ping

Ref #110440

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner January 23, 2021 00:33
@zakame zakame force-pushed the fixes/perl-Net-Async-Ping/skip-ping-socket-tests branch from 49a08c2 to f5db457 Compare January 23, 2021 11:47
@stigtsp
Copy link
Member

stigtsp commented Jan 23, 2021

@GrahamcOfBorg build perlPackages.NetAsyncPing perldevelPackages.NetAsyncPing

stigtsp
stigtsp approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stigtsp stigtsp merged commit 19f4c62 into NixOS:master Jan 23, 2021
@zakame
Copy link
Member Author

zakame commented Jan 24, 2021

Thanks @stigtsp @SuperSandro2000 ! 🎉

@zakame zakame deleted the fixes/perl-Net-Async-Ping/skip-ping-socket-tests branch January 24, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zakame @stigtsp @SuperSandro2000