Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger-live-desktop: 2.19.0 -> 2.20.0 #110513

Merged
merged 1 commit into from Jan 28, 2021
Merged

ledger-live-desktop: 2.19.0 -> 2.20.0 #110513

merged 1 commit into from Jan 28, 2021

Conversation

andresilva
Copy link
Member

@andresilva andresilva commented Jan 22, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andresilva
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 22, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@andresilva
Copy link
Member Author

Result of nixpkgs-review pr 110513 run on x86_64-linux 1

1 package built:
  • ledger-live-desktop

@glittershark
Copy link
Member

LGTM

@glittershark
Copy link
Member

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau January 22, 2021 17:24
@ofborg ofborg bot requested review from nyanloutre and Th0rgal January 22, 2021 17:30
@divanorama
Copy link
Contributor

Also compiles and starts ok on Gentoo amd64 sandbox=true

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 26, 2021

Reminder: Please review!

Reminder: This Pull Request is awaiting merger. If you are the assigned reviewer with commit permission, please have a look. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

Th0rgal
Th0rgal approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on my setup, it is working fine, lgtm

@marsam marsam merged commit f4a9d2a into NixOS:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glittershark glittershark glittershark approved these changes

@Th0rgal Th0rgal Th0rgal approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@RaghavSood RaghavSood Awaiting requested review from RaghavSood RaghavSood is a code owner

@timokau timokau Awaiting requested review from timokau

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andresilva @glittershark @divanorama @Th0rgal @marsam