[selectors] Move :focus-visible on <select> test to internal test #27288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 22, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2644906
branch
from
9222167
to
876f49b
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2644906
branch
from
876f49b
to
491c5b7
Compare
Browsers don't agree on when :focus-visible should match or not when a <select> element is clicked, and the spec leaves it open to each browser to decide what to do (see w3c/csswg-drafts#5822). So this patch removes the <select> element from external/wpt/css/selectors/focus-visible-002.html and puts it on an internal test: wpt_internal/css/selectors/focus-visible-select-001.html BUG=1148007 Change-Id: I6649ce6355aafc79b2fa3d258b2b69fa5a259ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644906 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#851627}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2644906
branch
from
491c5b7
to
7850a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers don't agree on when :focus-visible should match or not
when a <select> element is clicked, and the spec leaves it open
to each browser to decide what to do (see
w3c/csswg-drafts#5822).
So this patch removes the <select> element from
external/wpt/css/selectors/focus-visible-002.html
and puts it on an internal test:
wpt_internal/css/selectors/focus-visible-select-001.html
BUG=1148007
Change-Id: I6649ce6355aafc79b2fa3d258b2b69fa5a259ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644906
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#851627}