@turion told me to mention you here, @alexarice.

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110512 run on x86_64-linux 1

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110512 run on x86_64-darwin 1

I did some refactorings to test the interfaceFile function. I basically moved the function definition to lib.nix, which is imported as agdaLib and exposed as agda.lib.

Added assertion messages with the last push.

Another option would be using lib.extend to add the functions to lib for this scope (instead of passing round lib and agdaLib everywhere

Another option would be using lib.extend to add the functions to lib for this scope (instead of passing round lib and agdaLib everywhere

Sounds good. IIURC that also allow us to write pkgs.agdaPackages.lib.interfaceFile, which would also be better IMO. Unfortunately I don't know how to use lib.extend

I tried to replace

agdaLib = ...

with

lib = lib.extend (final: prev: {
  inherit (import ../build-support/agda/lib.nix {
    inherit lib;
  });
});

but this doesn't work.

Another option would be using lib.extend to add the functions to lib for this scope (instead of passing round lib and agdaLib everywhere

Sounds good. IIURC that also allow us to write pkgs.agdaPackages.lib.interfaceFile, which would also be better IMO. Unfortunately I don't know how to use lib.extend

I tried to replace

agdaLib = ...

with

lib = lib.extend (final: prev: {
  inherit (import ../build-support/agda/lib.nix {
    inherit lib;
  });
});

but this doesn't work.

You're first use of inherit doesn't really make sense here.

I think you want

lib = lib.extend (final: prev: import ../build-support/agda/lib.nix { inherit lib; });

On a side note I'm not sure if build-support is the right place for this to live, but I also don't know where would be better

EDIT: I made a mistake here, it should be { lib = prev; } instead of { inherit lib; } above

On a side note I'm not sure if build-support is the right place for this to live, but I also don't know where would be better

I believe I have a applied every suggestion now, besides the location for lib. Would pkgs/development/agda-modules be the correct place? Or do we want to leave it?

EDIT: I made a mistake here, it should be { lib = prev; } instead of { inherit lib; } above

Of course, I posted it wrong before.

@NixOS/ofborg test agda

Edit: This might have been the wrong command

@ofborg test agda

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/339

The aarch64 tests fail. If it is unclear why just mark it broken. Then we can merge I think.

Looking at the ofborg log (https://github.com/NixOS/nixpkgs/pull/110512/checks?check_run_id=1763878523, https://logs.nix.ci/?key=nixos/nixpkgs.110512&attempt_id=aff76ab4-d296-4a6a-a582-812206b972b0) I'm finding this error:

Calling: /nix/store/s6m8wrj6jkw15b6v5zzjq5z2ffhav4sc-ghc-8.10.3-with-packages/bin/ghc -O -o /tmp/HelloWorld -Werror -i/tmp -main-is MAlonzo.Code.HelloWorld /tmp/MAlonzo/Code/HelloWorld.hs --make -fwarn-incomplete-patterns -fno-warn-overlapping-patterns
[  1 of 130] Compiling MAlonzo.RTE      ( MAlonzo/RTE.hs, MAlonzo/RTE.o )
Compilation error:
<no location info>: error:
    Warning: Couldn't figure out LLVM version!
             Make sure you have installed LLVM 9
<no location info>: error:
    Warning: Couldn't figure out LLVM version!
             Make sure you have installed LLVM 9
ghc: could not execute: opt
error: 
Traceback (most recent call last):
  File "/nix/store/rygmgy4c0p0q8qkgk6ackryylps2g3bm-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 897, in run_tests
    exec(tests, globals())
  File "<string>", line 1, in <module>
  File "<string>", line 20, in <module>
  File "/nix/store/rygmgy4c0p0q8qkgk6ackryylps2g3bm-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 422, in succeed
    raise Exception(
Exception: command `agda -l standard-library -i . -c HelloWorld.agda` failed (exit code 1)
cleaning up
killing machine (pid 10)
(0.00 seconds)

It seems that on aarch64-linux, llvm isn't properly installed. I don't believe that's related to this PR.

I'm not sure the aarch64 tests have ever worked

Indeed they failed on master as well. I reported on #111738 with additional context. So I think we should be able to merge. I'll try and address that failure separately.