Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtxclient: Remove unneeded dependencies, add myself as maintainer. #110457

Merged
merged 1 commit into from Jan 23, 2021
Merged

mtxclient: Remove unneeded dependencies, add myself as maintainer. #110457

merged 1 commit into from Jan 23, 2021

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Jan 22, 2021 •
edited

Motivation for this change

mtxclient dropped dependencies on zlib and libsodium. They should be removed from the package.

I verified that they are not referenced by CMakeLists.txt any more, so the actual build isn't changed at all. On top of that nheko is currently the only depending package made by the same developers, so no weird edge cases should happen.
On top of that I'm currently using nheko with these changes without any issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pstn pstn marked this pull request as ready for review January 22, 2021 10:10
rnhmjoj
rnhmjoj approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built nheko with this and tested the chat a bit: looks all good to me.

@rnhmjoj rnhmjoj merged commit bba33c3 into NixOS:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pstn @rnhmjoj