python3Packages.capstone: aarch64 platform name #110548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urbas
force-pushed
the
python-capstone-aarch64-build-fix
branch
from
b8e3663
to
7de5f9d
Compare
SuperSandro2000
requested changes
Jan 23, 2021
|
Can't test but this looks sensible. |
urbas
force-pushed
the
python-capstone-aarch64-build-fix
branch
from
7de5f9d
to
25a1b3b
Compare
|
@jonringer is this approach acceptable? |
|
|
||
| src = capstone.src; | ||
| sourceRoot = "${capstone.name}/bindings/python"; | ||
|
|
||
| postPatch = '' | ||
| ln -s ${capstone}/lib/libcapstone${stdenv.targetPlatform.extensions.sharedLibrary} prebuilt/ | ||
| ln -s ${capstone}/lib/libcapstone.a prebuilt/ | ||
| '' + lib.optionalString stdenv.targetPlatform.isAarch64 '' | ||
| substituteInPlace setup.py --replace manylinux1 manylinux2014 |
There was a problem hiding this comment.
I thought about this a bit more and do you know if it would be save to apply on all platforms? Otherwise it might be forgotten with the next update.
There was a problem hiding this comment.
@SuperSandro2000: Indeed, that makes sense. I removed the conditional entirely. PTAL
urbas
force-pushed
the
python-capstone-aarch64-build-fix
branch
from
25a1b3b
to
b84835e
Compare
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
|
Result of 16 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This package currently doesn't build on aarch64 without this change.
This change fixes this build failure.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)