Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardnotes: fix for 3.5.11 #110531

Merged
merged 2 commits into from Jan 25, 2021
Merged

standardnotes: fix for 3.5.11 #110531

merged 2 commits into from Jan 25, 2021

Conversation

svrana
Copy link
Member

@svrana svrana commented Jan 22, 2021 •
edited

This is @tasmos rebased commit in #106521

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@svrana
standardnotes: fix for 3.5.11
84be5f6 
This is tasmos's rebased commit.
@ofborg ofborg bot requested a review from M-Gregoire January 22, 2021 19:39
@svrana @SuperSandro2000
Update pkgs/applications/editors/standardnotes/default.nix
2d5a07c 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

@mgregoire ping

M-Gregoire
M-Gregoire approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@M-Gregoire M-Gregoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :)

@SuperSandro2000 SuperSandro2000 merged commit 37c858e into NixOS:master Jan 25, 2021
@svrana
Copy link
Member Author

svrana commented Jan 25, 2021

thanks for 3.5.11 @tasmo !

@svrana svrana deleted the standard-notes-fixie branch January 25, 2021 16:47
@taku0 taku0 mentioned this pull request Feb 13, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@M-Gregoire M-Gregoire M-Gregoire approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@svrana @SuperSandro2000 @M-Gregoire