Added the basic <popup> element, with runtime enabled flag #27291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 22, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2644061
branch
from
7e72414
to
50a5160
Compare
This CL implements the basics of the new <popup> element, including the HTMLPopupElement prototype, the UA stylesheet CSS including open/hidden and position:fixed, promotion of content to the top-layer, and a Runtime Enabled flag to turn it on. Some basic WPT tests are included. See the explainer here: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/Popup/explainer.md Bug: 1168738 Change-Id: If9f8279c01a7055da49c51670804400d621deb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644061 Reviewed-by: Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#846409}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2644061
branch
from
50a5160
to
30a9a4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL implements the basics of the new <popup> element,
including the HTMLPopupElement prototype, the UA stylesheet
CSS including open/hidden and position:fixed, promotion of
content to the top-layer, and a Runtime Enabled flag to
turn it on. Some basic WPT tests are included.
See the explainer here:
https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/Popup/explainer.md
Bug: 1168738
Change-Id: If9f8279c01a7055da49c51670804400d621deb95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644061
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846409}