Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.ms-vsliveshare.vsliveshare-pack: Init at 0.4.0 #110461

Closed
wants to merge 1 commit into from
Closed

vscode-extensions.ms-vsliveshare.vsliveshare-pack: Init at 0.4.0 #110461

wants to merge 1 commit into from

Conversation

andyrichardson
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andyrichardson
Copy link
Contributor Author

Heads up, this uses the Microsoft Pre-Release Software License.

SuperSandro2000
SuperSandro2000 reviewed Jan 22, 2021
View reviewed changes
pkgs/misc/vscode-extensions/default.nix
publisher = "ms-vsliveshare";
version = "0.4.0";
sha256 = "sha256-xTdfOqdypAaWpmtYIM0H7gwCy1jXNl5+HarvVW/3AiY=";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing meta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See here. I would add the license to the project but it isn't listed on spdx 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add a license object here. Trex coping the definition from the licenses file, change the name and mark it unfree.

@andyrichardson
Copy link
Contributor Author

Looks like we're building from source for liveshare extensions which is failing on macOS.

Installation using this step seems to work fine without need for build from source - maybe I'm missing something (cc @grahamc)

@andyrichardson
Copy link
Contributor Author

Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyrichardson @SuperSandro2000