Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcrwallet: 1.5.1 -> 1.6.0 #110462

Merged
merged 1 commit into from Jan 28, 2021
Merged

dcrwallet: 1.5.1 -> 1.6.0 #110462

merged 1 commit into from Jan 28, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/decred/dcrwallet/releases.

meta.description for dcrwallet is: "A secure Decred wallet daemon written in Go (golang)"

meta.homepage for dcrwallet is: "https://decred.org"

meta.changelog for dcrwallet is: ""

Updates performed
  • Golang update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
dcrwallet
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/0i8j9ja9v8kk57b7x4jyg5r54xvbdrln-dcrwallet-1.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A dcrwallet https://github.com/r-ryantm/nixpkgs/archive/61857213718ea3fccba94747ad46343a5323d436.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/0i8j9ja9v8kk57b7x4jyg5r54xvbdrln-dcrwallet-1.6.0
ls -la /nix/store/0i8j9ja9v8kk57b7x4jyg5r54xvbdrln-dcrwallet-1.6.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • dcrwallet

Maintainer pings

cc @juaningan @kalbasit for testing.

@cole-h
Copy link
Member

cole-h commented Jan 24, 2021

EDIT: Seems to be caused by the fact that the commit (somehow) has 1000 statuses (https://docs.github.com/en/rest/reference/repos#statuses). However, looking at the statuses API (https://api.github.com/repos/NixOS/nixpkgs/statuses/61857213718ea3fccba94747ad46343a5323d436), it seems there are only 29 30 (oops, zero-indexed)... I don't know how they count this.

This can probably be worked around by force-pushing the commit. I'll probably ask someone somewhere how to determine if a commit has reached that 1000 status limit so we can add some logic to ofborg... Will look into this more tomorrow.


EDIT2: Submitted a ticket. We'll see what happens. Unless this update is urgently necessary, it would be nice to not use my previously-suggested force-push workaround, to keep the PR state as it was when the issue occurred. Might help GitHub Support debug. Though, they might have a "time machine" that makes this carefulness unnecessary, but 🤷


EDIT3: They got back to me (relatively quickly... pleasantly surprised) and apparently the API only shows 30 statuses per page. Using ?per_page=100&page=11 demonstrates how the grahamcofborg-eval context does indeed have 1000 statuses attached. At this time, I don't think there's any way to fix this in ofborg, because the cause is as clear as dirt. Just gonna force-push.

@marsam
Copy link
Contributor

marsam commented Jan 24, 2021

@GrahamcOfBorg eval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants