bucklespring: init at 2021-01-21 #110454
bucklespring: init at 2021-01-21 #110454
Conversation
| , libX11 | ||
| }: | ||
|
|
||
| with lib; |
There was a problem hiding this comment.
Please do not use with lib over the entire scope.
There was a problem hiding this comment.
i'm not going to add lib. in front of every optionals, that's ugly
but using it at meta is redundant xD
There was a problem hiding this comment.
That's how we usually do it in nixpkgs and using with lib over the entire file is way uglier than repeating lib a few times.
There was a problem hiding this comment.
with should always be used over the smallest scope possible and not over everything.
There was a problem hiding this comment.
changed to inherit optionals from lib
but did reintroduce with lib; at meta
| with lib; | ||
|
|
There was a problem hiding this comment.
| with lib; |
| ++ optionals (legacy) [ libXtst libX11 ] | ||
| ++ optionals (!legacy) [ libinput ]; | ||
|
|
||
| makeFlags = optionals (!legacy) [ "libinput=1" ]; |
There was a problem hiding this comment.
| ++ optionals (legacy) [ libXtst libX11 ] | |
| ++ optionals (!legacy) [ libinput ]; | |
| makeFlags = optionals (!legacy) [ "libinput=1" ]; | |
| ++ lib.optionals (legacy) [ libXtst libX11 ] | |
| ++ lib.optionals (!legacy) [ libinput ]; | |
| makeFlags = lib.optionals (!legacy) [ "libinput=1" ]; |
| , libX11 | ||
| }: | ||
|
|
||
| with lib; |
There was a problem hiding this comment.
with should always be used over the smallest scope possible and not over everything.
|
added a |
| let | ||
| inherit (lib) optionals; | ||
| in |
There was a problem hiding this comment.
| let | |
| inherit (lib) optionals; | |
| in |
evils
force-pushed
the
bucklespring
branch
2 times, most recently
from
d94a61e
to
e2e95db
Compare
|
Mind fixing up the commit message and PR title to match? Then I think this is good to go. |
right, done |
Motivation for this change
clickety clack keyboard's cool
Things done
packaged a tool to produce buckling spring keyboard sounds on keyboard events
added as 2 attributes as it can be built for X11 or to use libinput, with the default being X11 as that's more common
with libinput it works on wayland and even bare terminals, but requires the user running it to be in the
inputgroup (this is noted in the longDescription)this should maybe be set up via
programs.bucklespring.enablebut i got stuck on getting that to work a few too many times for something this sillyused the latest master commit because the latest release is 4 years old and several features have been added since
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)185854608forbucklespring-x11187148680forbucklespring-libinput