Skip to content

vscode-extensions.jpoissonnier.vscode-styled-components: Init at 1.4.1 #110458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2021
Merged

vscode-extensions.jpoissonnier.vscode-styled-components: Init at 1.4.1 #110458

merged 2 commits into from
Jan 22, 2021
+12 −0

Conversation

andyrichardson
Copy link
Contributor

@andyrichardson andyrichardson commented Jan 22, 2021 •
edited
Loading

Motivation for this change

VSCode Extension with 800k+ users - https://marketplace.visualstudio.com/items?itemName=emmanuelbeziat.vscode-great-icons

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 22, 2021
@SuperSandro2000 SuperSandro2000 merged commit eca1193 into NixOS:master Jan 22, 2021
@andyrichardson andyrichardson deleted the patch-8 branch February 22, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyrichardson @SuperSandro2000