Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create basic CanvasRenderingContext2D.reset test #27294

Merged
merged 1 commit into from Jan 25, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 22, 2021

Still need to create the following, but I wanted to add a basic one now
just to make sure we don't break the function, like happened here:
https://chromium-review.googlesource.com/c/chromium/src/+/2633345

I created a new file/folder as it didn't neatly fit anywhere else. Some
new tests that need to be added after this one:

  • Path is reset
  • Transformations are cleared
  • Clip is cleared
  • Style becomes default
  • Font also becomes default

Bug: 1131449
Change-Id: I87cf4d221d2603b534b2bbdec70d92679ee7d0bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645448
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846757}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Still need to create the following, but I wanted to add a basic one now
just to make sure we don't break the function, like happened here:
https://chromium-review.googlesource.com/c/chromium/src/+/2633345

I created a new file/folder as it didn't neatly fit anywhere else. Some
new tests that need to be added after this one:
  - Path is reset
  - Transformations are cleared
  - Clip is cleared
  - Style becomes default
  - Font also becomes default

Bug: 1131449
Change-Id: I87cf4d221d2603b534b2bbdec70d92679ee7d0bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645448
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846757}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants