Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.rstcheck: init at 3.3.1 #110553

Closed
wants to merge 2 commits into from
Closed

python3Packages.rstcheck: init at 3.3.1 #110553

wants to merge 2 commits into from

Conversation

dyrnade
Copy link
Contributor

@dyrnade dyrnade commented Jan 22, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [x ] Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 23, 2021
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/python-modules/rstcheck/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/rstcheck/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/rstcheck/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer reviewed Jan 24, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

python3Packages.rstcheck: init at 3.3.1

@jonringer jonringer changed the title rstcheck: init at 3.3.1 python3Packages.rstcheck: init at 3.3.1 Jan 24, 2021
@dyrnade dyrnade force-pushed the rstcheck branch 2 times, most recently from c9d0190 to e623d8f Compare January 24, 2021 21:32
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110553 run on x86_64-darwin 1

2 packages failed to build and are new build failures:
1 package built:
  • python38Packages.rstcheck

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.rstcheck:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110553 run on x86_64-linux 1

2 packages failed to build and are new build failures:
1 package built:
  • python38Packages.rstcheck

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.rstcheck:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@stale
Copy link

stale bot commented Jul 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 26, 2021
SuperSandro2000
SuperSandro2000 reviewed Aug 25, 2021
View reviewed changes
maintainers/maintainer-list.nix
Comment on lines 10492 to 10494
};

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
}
};
}

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 25, 2021
@braaandon braaandon mentioned this pull request Sep 1, 2021
Merged
12 tasks
@fabaff
Copy link
Member

fabaff commented Sep 4, 2021

Superseded by #136209

@fabaff fabaff closed this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dyrnade @SuperSandro2000 @fabaff @jonringer