Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube: 1.16.0 -> 1.17.0 #110552

Merged
merged 1 commit into from Jan 23, 2021
Merged

minikube: 1.16.0 -> 1.17.0 #110552

merged 1 commit into from Jan 23, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 22, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq marked this pull request as ready for review January 22, 2021 23:57
@zowoq zowoq merged commit f801396 into NixOS:master Jan 23, 2021
@zowoq zowoq deleted the minikube branch January 23, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chili-Man Chili-Man Chili-Man approved these changes

@ebzzry ebzzry Awaiting requested review from ebzzry

@vdemeester vdemeester Awaiting requested review from vdemeester

@kalbasit kalbasit Awaiting requested review from kalbasit

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @Chili-Man