Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsmartcols: Add gtk-doc to fix build. #110502

Merged
merged 1 commit into from Jan 22, 2021
Merged

libsmartcols: Add gtk-doc to fix build. #110502

merged 1 commit into from Jan 22, 2021

Conversation

rb2k
Copy link
Contributor

@rb2k rb2k commented Jan 22, 2021 •
edited

Motivation for this change

This is a bit odd. I created this package and I am not quite sure how that built before his change.
At the moment, it errors out complaining that gtkdocize can't be found:

autoreconf: running: gtkdocize --copy
Can't exec "gtkdocize": No such file or directory at /nix/store/63fda1bzb5wzza9y3wr21d1gn83g2nhf-autoconf-2.70/share/autoconf/Autom4te/FileUtils.pm line 293.

I tried to disable doc generation, but that's a bit of a mess and adding the dependency is easier.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rb2k rb2k changed the title libsmartcol: Add gtk-doc to fix build. libsmartcols: Add gtk-doc to fix build. Jan 22, 2021
@rb2k
Copy link
Contributor Author

rb2k commented Jan 22, 2021

Result of nixpkgs-review pr 110502 run on x86_64-linux 1

3 packages built:
  • libdnf
  • libsmartcols
  • microdnf

@rb2k rb2k requested a review from flokli January 22, 2021 15:56
@rb2k
Copy link
Contributor Author

rb2k commented Jan 22, 2021

Result of nixpkgs-review pr 110502 run on x86_64-darwin 1

3 packages built:
  • libdnf
  • libsmartcols
  • microdnf

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110502 run on x86_64-linux 1

3 packages built:
  • libdnf
  • libsmartcols
  • microdnf

@SuperSandro2000 SuperSandro2000 merged commit 27a42b9 into NixOS:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rb2k @SuperSandro2000