Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: enable F2FS compression #110542

Merged
merged 1 commit into from Jan 24, 2021
Merged

linux: enable F2FS compression #110542

merged 1 commit into from Jan 24, 2021

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jan 22, 2021 •
edited

Fixes #110534

The repro steps no longer repro the issue for me and the option is set.

Kernels <5.6 are unchanged.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu Atemu mentioned this pull request Jan 22, 2021
Closed
@Atemu
Copy link
Member Author

Atemu commented Jan 23, 2021

Unsure whether this should go to staging or not since it is an important feature but we only know of one user so far.

Could you test out this branch @tommy4st?

@SuperSandro2000
Copy link
Member

Unsure whether this should go to staging or not since it is an important feature but we only know of one user so far.

If only one person requires it is not that important IMO. I would send it through staging.

@tommy4st
Copy link

Could you test out this branch @tommy4st?

If I did it the correct way (clone the branch and run nixos-rebuild -I $branch-path switch), then everything works as expected. I can now assign the compress attribute and read the file.

nix-info shows:

  • system: "x86_64-linux"
  • host os: Linux 5.10.6-zen1, NixOS, 21.03.git.9d342077cd7 (Okapi)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.3.10
  • channels(root): "nixos-21.03pre265130.f217c0ea7c1, home-manager, nixos-hardware"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

@Atemu Atemu changed the base branch from master to staging January 23, 2021 20:18
lheckemann
lheckemann approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't affect most people since it's hidden away in the F2Fs module, and the change looks simple enough. 👍

@Mic92 Mic92 merged commit 7b13101 into NixOS:staging Jan 24, 2021
@Atemu Atemu deleted the kernel-f2fs-compression branch January 25, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann approved these changes

@vikanezrimaya vikanezrimaya Awaiting requested review from vikanezrimaya

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for F2FS compression in kernel is missing
5 participants
@Atemu @SuperSandro2000 @tommy4st @lheckemann @Mic92