Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: 6.1.16 -> 6.1.18 #110550

Merged
merged 1 commit into from Jan 25, 2021
Merged

virtualbox: 6.1.16 -> 6.1.18 #110550

merged 1 commit into from Jan 25, 2021

Conversation

bryanasdev000
Copy link
Member

@bryanasdev000 bryanasdev000 commented Jan 22, 2021 •
edited by SuperSandro2000

Motivation for this change

In addition to the normal package update, fix the build in the 5.10 kernel.

This closes #107648 and closes #108285.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bryanasdev000
virtualbox: 6.1.16 -> 6.1.18
72e688c 
Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
@bryanasdev000
Copy link
Member Author

I opened it as a draft because I'm still testing it.

This was referenced Jan 22, 2021
Closed
Closed
@flokli flokli requested a review from blitz January 22, 2021 23:28
@bryanasdev000 bryanasdev000 marked this pull request as ready for review January 23, 2021 03:16
@bryanasdev000
Copy link
Member Author

Did the same tests for this but only on latest zen 5.10, everything working.

@SuperSandro2000
Copy link
Member 

4 packages marked as broken and skipped:
linuxPackages_hardkernel_4_14.virtualbox linuxPackages_hardkernel_4_14.virtualboxGuestAdditions linuxPackages_hardkernel_latest.virtualbox linuxPackages_hardkernel_latest.virtualboxGuestAdditions

2 packages failed to build:
linuxPackages-libre.virtualbox linuxPackages-libre.virtualboxGuestAdditions    

39 packages built:
linuxPackages.virtualbox linuxPackages.virtualboxGuestAdditions linuxPackages_4_14.virtualbox linuxPackages_4_14.virtualboxGuestAdditions linuxPackages_4_19.virtualbox linuxPackages_4_19.virtualboxGuestAdditions linuxPackages_4_4.virtualbox linuxPackages_4_4.virtualboxGuestAdditions linuxPackages_4_9.virtualbox linuxPackages_4_9.virtualboxGuestAdditions linuxPackages_5_10.virtualbox linuxPackages_5_10.virtualboxGuestAdditions linuxPackages_5_9.virtualbox linuxPackages_5_9.virtualboxGuestAdditions linuxPackages_hardened.virtualbox linuxPackages_hardened.virtualboxGuestAdditions linuxPackages_latest-libre.virtualbox linuxPackages_latest-libre.virtualboxGuestAdditions linuxPackages_latest_hardened.virtualbox linuxPackages_latest_hardened.virtualboxGuestAdditions linuxPackages_latest_xen_dom0.virtualbox linuxPackages_latest_xen_dom0.virtualboxGuestAdditions linuxPackages_latest_xen_dom0_hardened.virtualbox linuxPackages_latest_xen_dom0_hardened.virtualboxGuestAdditions linuxPackages_lqx.virtualbox linuxPackages_lqx.virtualboxGuestAdditions linuxPackages_testing_bcachefs.virtualbox linuxPackages_testing_bcachefs.virtualboxGuestAdditions linuxPackages_xen_dom0.virtualbox linuxPackages_xen_dom0.virtualboxGuestAdditions linuxPackages_xen_dom0_hardened.virtualbox linuxPackages_xen_dom0_hardened.virtualboxGuestAdditions linuxPackages_zen.virtualbox linuxPackages_zen.virtualboxGuestAdditions virtualbox virtualboxExtpack virtualboxHardened virtualboxHeadless virtualboxWithExtpack

@flokli flokli merged commit 68b6d6c into NixOS:master Jan 25, 2021
@jfroche
Copy link
Contributor

jfroche commented Feb 9, 2021

@flokli Is it ok for you if we backport this to 20.09 ? I am facing the same problem when using 20.09 release

@flokli
Copy link
Contributor

flokli commented Feb 10, 2021

@jfroche sure, please file a PR against release-20.09 (with git cherry-pick -x as per our CONTRIBUTING.md) and highlight me on it :-)

@jfroche jfroche mentioned this pull request Feb 11, 2021
Merged
10 tasks
@blitz blitz mentioned this pull request Feb 11, 2021
Closed
10 tasks
@bryanasdev000 bryanasdev000 deleted the package-virtualbox-6.1.18 branch May 3, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@blitz blitz Awaiting requested review from blitz

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

virtualbox: Unable to compile VirtualBox kernel modules with kernel 5.10
4 participants
@bryanasdev000 @SuperSandro2000 @jfroche @flokli