Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] pythonPackages.pyyaml: 5.3.1 -> 5.4.1 #110525

Merged
merged 3 commits into from Jan 29, 2021
Merged

[staging] pythonPackages.pyyaml: 5.3.1 -> 5.4.1 #110525

merged 3 commits into from Jan 29, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 22, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer changed the title pythonPackages.pyyaml: 5.3.1 -> 5.4.1 [staging] pythonPackages.pyyaml: 5.3.1 -> 5.4.1 Jan 22, 2021
@jonringer

This comment has been minimized.

Sign in to view
@dotlambda
Copy link
Member Author

@ofborg build ceph

@jonringer
Copy link
Contributor

@GrahamcOfBorg build awscli

@jonringer
Copy link
Contributor

seems ceph is broken for other reasons

@dotlambda dotlambda added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 24, 2021
@dotlambda
Copy link
Member Author

This fixes CVE-2020-14343: https://github.com/yaml/pyyaml/blob/5.4.1/CHANGES

@dotlambda
Copy link
Member Author

@ofborg test awscli

@ofborg ofborg bot requested review from mweinelt, Mic92 and globin January 25, 2021 11:03
@dotlambda
Copy link
Member Author

I successfully ran the awscli test on my machine and built some other random packages.
However, I noticed that ddt fails: datadriventests/ddt#95.

@mweinelt mweinelt added this to WIP in Staging via automation Jan 25, 2021
@dotlambda
Copy link
Member Author

I suggest we merge and fix stuff later if we notice major breakage on Hydra.

@dotlambda
home-assistant: unpin PyYAML
c65a1ca 
Also remove a substitution that no longer applies.
@ofborg ofborg bot requested a review from mweinelt January 29, 2021 09:30
Staging automation moved this from WIP to Ready Jan 29, 2021
mweinelt
mweinelt approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/nix/store/ylpi5d68cx7rzbj462rizk5vhnilyb44-python3.8-PyYAML-5.4.1
/nix/store/dpc8948ssipm5rh3np4vrr9ymcambzw8-python3.7-PyYAML-5.4.1
/nix/store/8rn7rffvmnap2czlghb66yincy2s8vn7-python3.9-PyYAML-5.4.1

@mweinelt mweinelt merged commit 7e02052 into NixOS:staging Jan 29, 2021
Staging automation moved this from Ready to Done Jan 29, 2021
@dotlambda dotlambda deleted the pyyaml-5.4.1 branch January 29, 2021 15:43
@dotlambda dotlambda mentioned this pull request Feb 5, 2021
Merged
10 tasks
@dotlambda
Copy link
Member Author

dotlambda commented Mar 7, 2021 •
edited

20.09: #115343

@TredwellGit TredwellGit removed the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Mic92 Mic92 Awaiting requested review from Mic92

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @jonringer @mweinelt @TredwellGit