Skip to content

nix: add Security to build inputs. #110493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

nix: add Security to build inputs. #110493

merged 1 commit into from
Jan 22, 2021
+3 −0

Conversation

dhess
Copy link
Contributor

@dhess dhess commented Jan 22, 2021

For some reason, this is required to build nix on Big Sur, even though it's not needed on earlier macOS versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@dhess
nix: add Security to build inputs.
9088862 
For some reason, this is required to build nix on Big Sur, even though
it's not needed on earlier macOS versions.
@ofborg ofborg bot requested a review from edolstra January 22, 2021 15:06
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 22, 2021
@edolstra edolstra merged commit b60a6af into NixOS:master Jan 22, 2021
@matthewbauer
Copy link
Member

This should also be added on the Nix repo:

https://github.com/NixOS/nix/blob/480426a364f09e7992230b32f2941a09fb52d729/flake.nix#L83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhess @matthewbauer @edolstra