Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana-agent: fix rpath #110472

Merged
merged 1 commit into from Jan 22, 2021
Merged

grafana-agent: fix rpath #110472

merged 1 commit into from Jan 22, 2021

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 22, 2021

The library is in the lib output, not dev output.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
grafana-agent: fix rpath
28f04af 
The library is in the `lib` output, not `dev` output.
@ofborg ofborg bot requested a review from kalbasit January 22, 2021 12:31
@zimbatm
Copy link
Member

zimbatm commented Jan 22, 2021

Result of nixpkgs-review pr 110472 run on x86_64-linux 1

1 package built:
  • grafana-agent

@zimbatm zimbatm merged commit 45b32bf into NixOS:master Jan 22, 2021
@flokli flokli deleted the grafana-agent-fix-rpath branch January 22, 2021 14:14
@flokli
Copy link
Contributor Author

flokli commented Jan 22, 2021

cherry-picked to 20.09 in 3a60adc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @zimbatm