Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] pythonPackages.virtualenv: 20.2.1 -> 20.3.1 #110474

Merged
merged 4 commits into from Jan 31, 2021
Merged

[staging] pythonPackages.virtualenv: 20.2.1 -> 20.3.1 #110474

merged 4 commits into from Jan 31, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 22, 2021 •
edited

Motivation for this change

#109930 was reverted.

This pull request is problematic cause it disabled virtualenv on Python 2.7, which is no longer supported by pytest-freezegun. I do not understand how virtualenv manages to run the tests anyway: https://github.com/pypa/virtualenv/blob/20.4.0/setup.cfg#L97.
Solutions include

  • packaging a separate version of pytest-freezegun for Python 2.7 or
  • not running virtualenv's tests on Python 2.7.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer changed the title pythonPackages.virtualenv: 20.2.1 -> 20.3.1 [staging] pythonPackages.virtualenv: 20.2.1 -> 20.3.1 Jan 22, 2021
@dotlambda
Copy link
Member Author

Any suggestions regarding Python 2.7?

@dotlambda dotlambda requested a review from FRidh January 23, 2021 21:04
@jonringer
Copy link
Contributor

Any suggestions regarding Python 2.7?

it's been EOL for over a year.

However, if I would "pin" the python2 version to 20.2.1 if it is necessary for the few remaining packages dependent on it.

@dotlambda
Copy link
Member Author

I was able to avoid disabling pytest-freezegun on Python 2.7 by updating python2Packages.freezegun.

@dotlambda dotlambda marked this pull request as ready for review January 24, 2021 10:52
@SuperSandro2000
Copy link
Member

@jonringer can you please take another look at this?

@dotlambda dotlambda merged commit d98e256 into NixOS:staging Jan 31, 2021
@dotlambda dotlambda deleted the virtualenv-20.3.1 branch January 31, 2021 08:30
@cole-h cole-h mentioned this pull request Mar 2, 2021
Merged
10 tasks
@cole-h
Copy link
Member

cole-h commented Mar 2, 2021

Adding fish as a checkInput to python3Packages.virtualenv means that everything that touches fish becomes a mass-rebuild for everything that depends on python3Packages.virtualenv. I've opened #114809 to remove this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff Awaiting requested review from fabaff

@jonringer jonringer Awaiting requested review from jonringer

@Mic92 Mic92 Awaiting requested review from Mic92

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@FRidh FRidh Awaiting requested review from FRidh

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @jonringer @SuperSandro2000 @cole-h @fabaff