agda.withPackages: use GHC with ieee754 as default #110501
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in the package description of ieee on Hackage, ieee is deprecated in favor of ieee754.
ofborg
bot
added
8.has: documentation
neosimsim
force-pushed
the
agda-ghc-ieee754
branch
from
ceb4424 to
63fea09
Compare
|
@turion told me that I should mention you, @alexarice. |
turion
approved these changes
Jan 22, 2021
alexarice
approved these changes
Jan 22, 2021
ofborg
bot
added
the
6.topic: nixos
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
neosimsim
commented
Jan 24, 2021
Test that the compiled executable actually runs.
neosimsim
force-pushed
the
agda-ghc-ieee754
branch
from
63fea09 to
67e43b7
Compare
turion
approved these changes
Feb 2, 2021
alexarice
approved these changes
Feb 2, 2021
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
veprbl
added
the
6.topic: agda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As mentioned in the package description of ieee on Hackage,
ieee is deprecated in favor of ieee754.
Things done
Change default
ghcWithPackagesinagda.withPackages.sandboxinnix.confon non-NixOS linux)See "Hello World" in nixos/tests/agda.nix