Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agda.withPackages: use GHC with ieee754 as default #110501

Merged
merged 2 commits into from Feb 3, 2021
Merged

agda.withPackages: use GHC with ieee754 as default #110501

merged 2 commits into from Feb 3, 2021

Conversation

neosimsim
Copy link
Contributor

@neosimsim neosimsim commented Jan 22, 2021 •
edited

Motivation for this change

As mentioned in the package description of ieee on Hackage,
ieee is deprecated in favor of ieee754.

Things done

Change default ghcWithPackages in agda.withPackages.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    See "Hello World" in nixos/tests/agda.nix
  • Ensured that relevant documentation is up to date

@neosimsim
agda.withPackages: use GHC with ieee754 as default
b4b4e36 
As mentioned in the package description of ieee on Hackage,
ieee is deprecated in favor of ieee754.
@neosimsim neosimsim marked this pull request as ready for review January 22, 2021 16:30
@neosimsim
Copy link
Contributor Author

@turion told me that I should mention you, @alexarice.

@turion
Copy link
Contributor

turion commented Jan 22, 2021

See http://hackage.haskell.org/package/ieee

alexarice
alexarice approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agda documentation seems to also recommend ieee754 now

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110501 run on x86_64-linux 1

1 package built:
  • agda

neosimsim
neosimsim commented Jan 24, 2021
View reviewed changes
nixos/tests/agda.nix Outdated Show resolved Hide resolved
@neosimsim
nixos/tests/agda: check execution of HelloWorld
67e43b7 
Test that the compiled executable actually runs.
@turion turion requested a review from alexarice February 2, 2021 17:45
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/338

@AndersonTorres AndersonTorres merged commit a27a2c4 into NixOS:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turion turion turion approved these changes

@alexarice alexarice alexarice approved these changes

Assignees
No one assigned
Labels
6.topic: agda 6.topic: nixos 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@neosimsim @turion @SuperSandro2000 @nixos-discourse @alexarice @veprbl @AndersonTorres