Server: properly delete ServerMap on interrupted startups

SmallJoker · SmallJoker · commit d287da184cff · 2021-02-05T18:38:34.000+01:00
A static mod error (e.g. typo) would abort the initialization but never free ServerMap
diff --git a/src/map_settings_manager.cpp b/src/map_settings_manager.cpp
@@ -116,7 +116,8 @@ bool MapSettingsManager::saveMapMeta()
 {
 	// If mapgen params haven't been created yet; abort
 	if (!mapgen_params) {
-		errorstream << "saveMapMeta: mapgen_params not present!" << std::endl;
+		infostream << "saveMapMeta: mapgen_params not present! "
+			<< "Server startup was probably interrupted." << std::endl;
 		return false;
 	}
 
diff --git a/src/server.cpp b/src/server.cpp
@@ -351,6 +351,7 @@ Server::~Server()
 	// Deinitialize scripting
 	infostream << "Server: Deinitializing scripting" << std::endl;
 	delete m_script;
+	delete m_startup_server_map; // if available
 	delete m_game_settings;
 
 	while (!m_unsent_map_edit_queue.empty()) {
@@ -399,6 +400,7 @@ void Server::init()
 
 	// Create the Map (loads map_meta.txt, overriding configured mapgen params)
 	ServerMap *servermap = new ServerMap(m_path_world, this, m_emerge, m_metrics_backend.get());
+	m_startup_server_map = servermap;
 
 	// Initialize scripting
 	infostream << "Server: Initializing Lua" << std::endl;
@@ -440,6 +442,7 @@ void Server::init()
 	m_craftdef->initHashes(this);
 
 	// Initialize Environment
+	m_startup_server_map = nullptr; // Ownership moved to ServerEnvironment
 	m_env = new ServerEnvironment(servermap, m_script, this, m_path_world);
 
 	m_inventory_mgr->setEnv(m_env);
diff --git a/src/server.h b/src/server.h
@@ -547,6 +547,10 @@ class Server : public con::PeerHandler, public MapEventReceiver,
 	// Environment
 	ServerEnvironment *m_env = nullptr;
 
+	// Reference to the server map until ServerEnvironment is initialized
+	// after that this variable must be a nullptr
+	ServerMap *m_startup_server_map = nullptr;
+
 	// server connection
 	std::shared_ptr<con::Connection> m_con;
 

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,8 @@ bool MapSettingsManager::saveMapMeta()`
`116`	`116`	`{`
`117`	`117`	`// If mapgen params haven't been created yet; abort`
`118`	`118`	`if (!mapgen_params) {`
`119`		`- errorstream << "saveMapMeta: mapgen_params not present!" << std::endl;`
	`119`	`+ infostream << "saveMapMeta: mapgen_params not present! "`
	`120`	`+ << "Server startup was probably interrupted." << std::endl;`
`120`	`121`	`return false;`
`121`	`122`	`}`
`122`	`123`