Fix #8676: Revert a2c3197f4 and unconditionally load settings "early" #8677
+30
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's another possible fix in master...michicc:pr/fix_gui_zoom_setting (#8678) |
|
I remembered that "minimal" settings may only be loaded once. Fall-back fonts and other auto-detected/fixed stuff may change, so loading the "minimal" settings a second time would break that. Loading the non-minimal settings earlier should be fine. Though maybe we should start adding comments :p |
|
Already fixed 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
gui.zoom_minandgui.zoom_maxwhere moved to_misc_settingswhile settings windows was still expecting them in_settings.The move was to have these settings available early, to update GUI zoom level before drawing anything.
Description
Reverted the move, as it caused the issue.
Since settings are reloaded after each grf scan, it should not be an issue to always load them, even in the "early" load.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.