Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [CMake] Language files should depend on english.txt #8637

Merged
merged 1 commit into from Feb 2, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Feb 1, 2021

Motivation / Problem

When trying something implying a modification in english.txt, I noticed other languages were not recompiled, and consequently were not available in game.

Description

I added english.txt as dependency for all lang files.
While at it I simplified table/strings.h to depend only on english.txt

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glx22 glx22 merged commit 1449919 into OpenTTD:master Feb 2, 2021
@glx22 glx22 deleted the langs branch February 2, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants