Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 983a0c9efa7d
Choose a base ref
...
head repository: NixOS/nix
compare: b10e3bc5ea5b
Choose a head ref
  • 9 commits
  • 11 files changed
  • 2 contributors

Commits on May 19, 2021

  1. Merge pull request #4834 from NixOS/generic-closure-function 

    Extract a generic `computeClosure` function
    @edolstra
    edolstra committed May 19, 2021
    Copy the full SHA
    af4ff64 View commit details
    Browse the repository at this point in the history

  2. Always send the realisations as JSON 

    Align all the worker protocol with `buildDerivation` which inlines the
realisations as one opaque json blob.
That way we don’t have to bother changing the remote store protocol
when the definition of `Realisation` changes, as long as we keep the
json backwards-compatible
    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    2197bc2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ca/json-realisations-in-worker-protocol'

    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    2c80760 View commit details
    Browse the repository at this point in the history

  4. Add a dependencies field to DrvOutputInfo 

    Currently never used, nor set but will be useful shortly
    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    9b1c35c View commit details
    Browse the repository at this point in the history

  5. Store the realisation deps on the local store

    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    dbcf085 View commit details
    Browse the repository at this point in the history

  6. Add a method to compute the closure of a realisation 

    Only considers the closure in term of `Realisation`, ignores all the
opaque inputs.

Dunno whether that’s the nicest solution, need to think it through a bit
    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    e0de25d View commit details
    Browse the repository at this point in the history

  7. Properly track the drvoutput references when building

    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    b4e5c4d View commit details
    Browse the repository at this point in the history

  8. Make copyPaths copy the whole realisations closure 

    Otherwise registering the realisations on the remote side might fail as
it now expects a complete closure
    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    f7b1777 View commit details
    Browse the repository at this point in the history

  9. Add a db migration script

    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    b10e3bc View commit details
    Browse the repository at this point in the history