Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tropical Lumber Mill doesn't work properly on large maps #9242

Closed
vituscze opened this issue May 11, 2021 · 2 comments
Closed

Tropical Lumber Mill doesn't work properly on large maps #9242

vituscze opened this issue May 11, 2021 · 2 comments

Comments

@vituscze
Copy link
Contributor

Version of OpenTTD

1.11.2, Windows 10

Expected result

The production of a tropical lumber mill should be independent of the map size.

Actual result

A 40x40 section of a rainforest on a 64x64 map can support up to about 80 lumber mills. The same area cannot support even one lumber mill on a 4096x4096 map (the lumber mill eventually runs out of trees to chop down).

In other words, the random tree growth does not scale with map size.
@PeterN
Copy link
Member

PeterN commented May 11, 2021

Yes, tree growth is not scaled by map size at all, so the baseline should be the growth rate of a 256x256 map. 64x64 should be reduced.

@James103
Copy link
Contributor

In other words, the "Expected result" should be that a 40x40 section of a rainforest on a 256x256 map should be able to support up to 4 or 5 lumber mills at full production and default tree growth rates, regardless of the map size.

PeterN added a commit to PeterN/OpenTTD that referenced this issue May 11, 2021
@PeterN
Fix OpenTTD#9242: Tree tick handler did not scale by map size.
44db3ee 
This means that random tree generation density is higher on small maps and lower on large maps. This difference is enough to make the Lumber Mill impractical to use on large maps.

This change skips ticks on maps smaller than 256x256 and increases iterations or shortens the interval on maps larger than 256x256.
PeterN added a commit to PeterN/OpenTTD that referenced this issue May 11, 2021
@PeterN
Fix OpenTTD#9242: Tree tick handler did not scale by map size.
02c6237 
This means that random tree generation density is higher on small maps and lower on large maps. This difference is enough to make the Lumber Mill impractical to use on large maps.

This change skips ticks on maps smaller than 256x256 and increases iterations or shortens the interval on maps larger than 256x256.
@PeterN PeterN mentioned this issue May 11, 2021
Merged
PeterN added a commit to PeterN/OpenTTD that referenced this issue May 11, 2021
@PeterN
Fix OpenTTD#9242: Tree tick handler did not scale by map size.
3c66a91 
This means that random tree generation density is higher on small maps and lower on large maps. This difference is enough to make the Lumber Mill impractical to use on large maps.

This change skips ticks on maps smaller than 256x256 and increases iterations or shortens the interval on maps larger than 256x256.
@PeterN PeterN closed this as completed in b972ed8 May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PeterN @vituscze @James103