Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tree brushes do not mark tiles as a rainforest #9241

Closed
vituscze opened this issue May 11, 2021 · 2 comments
Closed

Some tree brushes do not mark tiles as a rainforest #9241

vituscze opened this issue May 11, 2021 · 2 comments

Comments

@vituscze
Copy link
Contributor

Version of OpenTTD

1.11.2, Windows 10

Expected result

Planting rainforest trees in the scenario editor should create rainforest tiles.

Actual result

Only the "normal" brush creates rainforest tiles, "grove" and "forest" brushes do not.
@vituscze
Copy link
Contributor Author

Left: normal brush, right: grove brush

image

Minimap after demolishing the area:

image

The same area after some time:

image

@2TallTyler
Copy link
Member

2TallTyler commented May 14, 2021 •
edited

Did a bit of digging regarding this. The normal brush uses CmdPlantTree() (which properly sets the rainforest tile), while the grove and forest brushes use PlaceTreeGroupAroundTile() (which does not). I'm not sure why PlaceTreeGroupAroundTile() plants trees in a totally different way than simply calling CmdPlaceTree(), but I assume there's a good reason.

vituscze added a commit to vituscze/OpenTTD that referenced this issue Jun 17, 2021
@vituscze
Fix OpenTTD#9241: Grove and forest tree brushes also create rainforests
cb560da
@vituscze vituscze mentioned this issue Sep 5, 2021
Merged
vituscze added a commit to vituscze/OpenTTD that referenced this issue Sep 5, 2021
@vituscze
Fix OpenTTD#9241: Grove and forest tree brushes also create rainforests
072caa3
vituscze added a commit to vituscze/OpenTTD that referenced this issue Sep 7, 2021
@vituscze
Fix OpenTTD#9241: Grove and forest tree brushes also create rainforests
f0fc223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vituscze @2TallTyler